Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for MRIReco to 0.8, (keep existing compat) #213

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the MRIReco package from 0.6, 0.7 to 0.6, 0.7, 0.8.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0141242) 87.60% compared to head (0d4a40f) 87.60%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files          33       33           
  Lines        2251     2251           
=======================================
  Hits         1972     1972           
  Misses        279      279           
Flag Coverage Δ
base 86.30% <ø> (ø)
core 79.40% <ø> (ø)
files 86.06% <ø> (ø)
komamri 93.88% <ø> (ø)
plots 93.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cncastillo
Copy link
Member

cncastillo commented Nov 28, 2023

Please fix this (MRIReco v0.8 not working on Julia v1.9) for the next version @beorostica.

@beorostica
Copy link
Contributor

Now the master branch is considering the version 0.8 of MRIReco. We can close this pull request.

@beorostica
Copy link
Contributor

I'm going to close this pull request since these changes are already reflected in the master branch.

@beorostica beorostica closed this Jan 11, 2024
@beorostica beorostica deleted the compathelper/new_version/2023-11-15-00-34-36-642-02242792321 branch January 19, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants