Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HDF5 to downstream tests #40

Closed
wants to merge 2 commits into from
Closed

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Dec 17, 2024

HDF5 unfortunately depends on internal CodecBzip2 functions, so regular tests might not catch compatibility issues.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (5ce971b) to head (6851517).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files           4        4           
  Lines         126      126           
=======================================
  Hits          107      107           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2
Copy link
Member Author

nhz2 commented Dec 17, 2024

This isn't working because HDF5 is doing some strange Pkg stuff in runtests.jl

@nhz2 nhz2 closed this Dec 17, 2024
@nhz2 nhz2 deleted the nz/more-downstream-tests branch December 17, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant