Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename FORMER_STDLIBS -> UPGRADABLE_STDLIBS #4070

Merged
merged 1 commit into from
Dec 2, 2024
Merged

rename FORMER_STDLIBS -> UPGRADABLE_STDLIBS #4070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,8 @@ is_project_uuid(env::EnvCache, uuid::UUID) = project_uuid(env) == uuid
# Context #
###########

const FORMER_STDLIBS = ["DelimitedFiles", "Statistics"]
const FORMER_STDLIBS_UUIDS = Set{UUID}()
const UPGRADABLE_STDLIBS = ["DelimitedFiles", "Statistics"]
const UPGRADABLE_STDLIBS_UUIDS = Set{UUID}()
const STDLIB = Ref{DictStdLibs}()
function load_stdlib()
stdlib = DictStdLibs()
Expand All @@ -473,8 +473,8 @@ function load_stdlib()
v_str = get(project, "version", nothing)::Union{String, Nothing}
version = isnothing(v_str) ? nothing : VersionNumber(v_str)
nothing === uuid && continue
if name in FORMER_STDLIBS
push!(FORMER_STDLIBS_UUIDS, UUID(uuid))
if name in UPGRADABLE_STDLIBS
push!(UPGRADABLE_STDLIBS_UUIDS, UUID(uuid))
continue
end
deps = UUID.(values(get(project, "deps", Dict{String,Any}())))
Expand All @@ -499,7 +499,7 @@ end
is_stdlib(uuid::UUID) = uuid in keys(stdlib_infos())
# Includes former stdlibs
function is_or_was_stdlib(uuid::UUID, julia_version::Union{VersionNumber, Nothing})
return is_stdlib(uuid, julia_version) || uuid in FORMER_STDLIBS_UUIDS
return is_stdlib(uuid, julia_version) || uuid in UPGRADABLE_STDLIBS_UUIDS
end


Expand Down
Loading