win: compute parallelism from process cpu affinity (#4521) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GetProcessAffinityMask() to estimate the available parallelism. Before this commit, it simply used the number of available CPUs. Fixes: libuv#4520 (cherry picked from commit 58dfb6c)
|
I'm inclined to merge this PR and #39 in a couple of days if there are no objections, they're simply backports of commits already in upstream, hopefully not very controversial. |
giordano
added a commit
to giordano/Yggdrasil
that referenced
this pull request
Aug 31, 2024
This includes * JuliaLang/libuv#38, backport of libuv/libuv#4521 * JuliaLang/libuv#39, backport of libuv/libuv#4278
giordano
added a commit
to giordano/Yggdrasil
that referenced
this pull request
Aug 31, 2024
This includes * JuliaLang/libuv#38, backport of libuv/libuv#4521 * JuliaLang/libuv#39, backport of libuv/libuv#4278
giordano
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Aug 31, 2024
This includes * JuliaLang/libuv#38, backport of libuv/libuv#4521 * JuliaLang/libuv#39, backport of libuv/libuv#4278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uv_available_parallelismon Windows is currently inconsistent withuv_thread_getaffinity. This backports libuv#4521 which fixes this issue.