Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize angle and sign #133

Closed
wants to merge 1 commit into from
Closed

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 26, 2022

These were being specialized in ApproxFunBase, but it's best to avoid the type-piracy and move the methods to this package. These are useful for complex intervals.

julia> iv = 0..im
0 + 0im..0 + 1im

julia> angle(iv)  pi/2
true

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 99.16% // Head: 99.17% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b9b2b5b) compared to base (c88d162).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   99.16%   99.17%   +0.01%     
==========================================
  Files           3        3              
  Lines         240      243       +3     
==========================================
+ Hits          238      241       +3     
  Misses          2        2              
Impacted Files Coverage Δ
src/IntervalSets.jl 98.36% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hyrodium
Copy link
Collaborator

What's the mathematical meaning of 0..im? (x-ref: #47)

@hyrodium
Copy link
Collaborator

I believe we don't need support for complex numbers. Please reopen this issue or comment here if you have any additional thoughts.

@hyrodium hyrodium closed this May 10, 2023
@jishnub jishnub deleted the anglesign branch May 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants