Allow allocs for union types on older Julia versions

JuliaObjects · Jul 27, 2024 · 812884d · 812884d
1 parent ac65fcd
commit 812884d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/ConstructionBase.jl b/src/ConstructionBase.jl
@@ -234,7 +234,7 @@ setproperties_object(obj, patch::NamedTuple{()}) = obj
     pnames = fieldnames(patch)
     for fname in fieldnames(obj)
         source = fname in pnames ? :patch : :obj
-        push!(args, :(getfield($source, $(QuoteNode(fname)))))
+        push!(args, :(getproperty($source, $(QuoteNode(fname)))))
     end
     :(constructorof(typeof(obj))($(args...)))
 end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -484,7 +484,11 @@ end
 @testset "no allocs S2" begin
     obj = S2(3, UInt32(5))
     @test 0 == hot_loop_allocs(constructorof, typeof(obj))
-    @test 0 == hot_loop_allocs(setproperties, obj, (; a = nothing, b = Int32(6)))
+    if VERSION ≤ v"1.3"
+        @test 32 == hot_loop_allocs(setproperties, obj, (; a = nothing, b = Int32(6)))
+    else
+        @test 0 == hot_loop_allocs(setproperties, obj, (; a = nothing, b = Int32(6)))
+    end
 end
 
 @testset "inference" begin