Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cpu_features #3710

Closed

Conversation

Crghilardi
Copy link
Contributor

This PR adds a build_tarballs.jl for the cpu_features library.

This works for me on the regular platforms I test on, but there are a few commits on master that are not in the release that I may need to pull in still for the apple-* platforms.

The top level CMake file also strongly recommends building as a static library, so I didn't mess with anything and just produce the executable currently.

@Crghilardi Crghilardi force-pushed the cg/add-cpu-features branch from 181133e to e16f57a Compare October 8, 2021 02:31
@vchuravy
Copy link
Member

vchuravy commented Oct 8, 2021

How do you plan to use it? From Julia you will need a shared library, or a costly shell out to the command line.

Do you need it as a dependency for something else?

@Crghilardi
Copy link
Contributor Author

I was hoping to use it as a dependency for volk. They have cpu_features as a submodule, but I thought bringing it in as a JLL and modifying the cmake to point to the JLL instead might be better?

I need to do some testing, but looking at it now I think I should be able to apply the patch from here to the submodule instead and then we can close this.

@Crghilardi Crghilardi mentioned this pull request Oct 9, 2021
@giordano
Copy link
Member

Since the only point of this was to be a dependency of VOLK and VOLK has been built in #3718 using cpu_features as a static library (?), maybe this can be closed?

@Crghilardi Crghilardi closed this Oct 10, 2021
@Crghilardi Crghilardi deleted the cg/add-cpu-features branch October 10, 2021 19:01
@Crghilardi Crghilardi mentioned this pull request Oct 19, 2021
@Crghilardi Crghilardi mentioned this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants