Fix Zombie Attack with MTK notebook #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see fonsp/Pluto.jl#3080 also the system diff table was not working anymore so I commented it out -> it can come back after fix
|
Well turns out the JS bug doesn't seem to be a problem. The current version (on main) seems to work fine now? @fonsp Do you remember what was going wrong with it? As in, in what way was it not working anymore ? |
|
Nice! It's working! Can you also fix the colors? Try the notebook in both light mode and dark mode on your computer 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I fix the notebook?
At least it's now running on my local setup and got rid of the JS error which I suspect was causing the notebook to fail to run.
see fonsp/Pluto.jl#3080
also the system diff table was not working anymore so I commented it out
-> it can come back after fix
Is there a way to test it out without merging on main?