Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict StaticArrays.jl @v1.5.16- to Julia v1.10- #121870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fhagemann
Copy link
Contributor

Repeating #116935 :

Following up on #86950 (comment):
In #86950, the julia compat was restricted to ≤ 1.10 for [email protected].
However, the code which errors was only removed in 1.5.17, see here.

This change was already merged in #116935, but reverted in #117626 because of tests failing in Pkg.jl (which were pulling [email protected]).

I proposed a change in the Pkg tests in JuliaLang/Pkg.jl#4077, where now [email protected] is pulled instead of [email protected].

Now, remerging #116935 should be fine.

Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Jan 22, 2025
@fhagemann
Copy link
Contributor Author

Maybe someone could have a look at this. This PR was originally approved, reverted because it was breaking the Pkg tests. But the Pkg tests have been fixed in the mean time.

@github-actions github-actions bot removed the stale label Jan 23, 2025
@fhagemann
Copy link
Contributor Author

@carstenbauer @giordano 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant