ak/abstract_types #915
Closed
ak/abstract_types #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @adam-r-kowalski. Have you looked at #882 which should be merged soon? |
|
@adam-r-kowalski there are some conflicts, can you fix them? Afterwards there should be only one change remaining, which you should test with a non-standard array |
|
closing this for the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use this with Flux Tracked Arrays I needed to loosen the restrictions on the types to be more abstract. Additionally the eltype was previously hard coded to be Float64 and it should depend on the type parameter of the distribution.