Skip to content

Commit

Permalink
Matrixify qr.Q instead collecting (#210)
Browse files Browse the repository at this point in the history
  • Loading branch information
dkarrasch authored Feb 12, 2023
1 parent 4f77cec commit ebeaa4d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ keywords = ["multivariate statistics", "dimensionality reduction"]
license = "MIT"
desc = "A Julia package for multivariate statistics and data analysis"
repository = "https://github.com/JuliaStats/MultivariateStats.jl.git"
version = "0.10.0"
version = "0.10.1"

[deps]
Arpack = "7d9fca2a-8960-54d3-9f78-7d1dccf2cb97"
Expand Down
2 changes: 1 addition & 1 deletion test/pca.jl
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ import SparseArrays
d = 5
n = 1000

R = collect(qr(randn(rng, d, d)).Q)
R = Matrix(qr(randn(rng, d, d)).Q)
@test R'R Matrix(I, 5, 5)
rmul!(R, Diagonal(sqrt.([0.5, 0.3, 0.1, 0.05, 0.05])))

Expand Down

2 comments on commit ebeaa4d

@dkarrasch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/77522

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.10.1 -m "<description of version>" ebeaa4d981e4905022c6a74464b9fa1dcce87f19
git push origin v0.10.1

Please sign in to comment.