Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted (DARK) version of RockMargin for VS2022 Dark Theme #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

neofuturelabs
Copy link

Hello everyone,

I've been a fan of RockScroll/MetalScroll/RockMargin since one of its early iterations. One of the few issues I've had with the extension is how the default colors clash with the color theme of Visual Studio's Dark Mode. Furthermore, it's annoying to have to manually input the ARGB color settings every time after installing the extension.

So here are the two modifications I've included in this pull request (built on top of ArkEcho's VS2022 pull request "pr/1"):

  • Changed the default colors and width to look good in Dark Mode. Adjusted the order of settings in the default settings code to match the actual settings order in the Options menu (to make it easier to adjust).
  • Removed the Monitoring / IPLookup related code, as sending my IP address, Machine Name, and City to a random server (in Kyiv?) doesn't match my use-case for this extension. I suppose the crash-reporting code could be useful if the extension is being actively maintained (is it?), but I don't see why MonitoringService.SendPresense needs to be called in CreateMargin.

Feel free to integrate or not integrate these commits into the main branch, or any personal branches as you would like.

If anyone wants to really go above-and-beyond, adding a system to select from several default color themes would probably be ideal. Furthermore, I'm not sure why the RockMargin settings aren't properly exported/imported when backing up your Visual Studio user settings, so that might be worth looking into as well.

I uploaded the generated .vsix extension installer file here for convenience:
https://www.neofuturelabs.com/vsix/RockMargin_Dark.vsix

Screenshot
RockMargin_Dark

By the way, this is my first contribution on GitHub, so I hope I'm doing this right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants