fix: use userland module for punycode (tediousjs#1596)

* Use userland module for punycode The slash at the end is necessary to use the userland module * fix: Add @types/punycode as dev dependency --------- Co-authored-by: Eli Frigo <[email protected]> (cherry picked from commit 6a961b5)
KAMAELUA · Apr 29, 2024 · b960684 · b960684
1 parent 9326807
commit b960684
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -69,6 +69,7 @@
     "@types/lru-cache": "^5.1.1",
     "@types/mocha": "^10.0.1",
     "@types/node": "^16.18.38",
+    "@types/punycode": "^2.1.3",
     "@types/sprintf-js": "^1.1.2",
     "@typescript-eslint/eslint-plugin": "^6.0.0",
     "@typescript-eslint/parser": "^6.0.0",

diff --git a/src/connector.ts b/src/connector.ts
@@ -1,7 +1,7 @@
 import net from 'net';
 import dns, { type LookupAddress } from 'dns';
 
-import * as punycode from 'punycode';
+import * as punycode from 'punycode/';
 import { AbortSignal } from 'node-abort-controller';
 import AbortError from './errors/abort-error';
 

diff --git a/src/sender.ts b/src/sender.ts
@@ -1,7 +1,7 @@
 import dgram from 'dgram';
 import dns from 'dns';
 import net from 'net';
-import * as punycode from 'punycode';
+import * as punycode from 'punycode/';
 import { AbortSignal } from 'node-abort-controller';
 
 import AbortError from './errors/abort-error';

diff --git a/test/unit/connector-test.js b/test/unit/connector-test.js
@@ -1,6 +1,6 @@
 const Mitm = require('mitm');
 const sinon = require('sinon');
-const punycode = require('punycode');
+const punycode = require('punycode/');
 const assert = require('chai').assert;
 const { AbortController } = require('node-abort-controller');
 const AggregateError = require('es-aggregate-error');

diff --git a/test/unit/instance-lookup-test.js b/test/unit/instance-lookup-test.js
@@ -1,5 +1,5 @@
 const sinon = require('sinon');
-const punycode = require('punycode');
+const punycode = require('punycode/');
 const assert = require('chai').assert;
 const dgram = require('dgram');
 const { AbortController } = require('node-abort-controller');