Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharma - Update medication function use for upcoming ACE v3.18.2 #684

Conversation

mrschick
Copy link
Contributor

@mrschick mrschick commented Jan 1, 2025

When merged this pull request will:

  • Update the use of ACE Medical functions that were recently changed by Medical - Add medication dosage support & improve overdose acemod/ACE3#10393, to prevent broken medication behaviour once ACE v3.18.2 is released:
    • 2 params were removed from medical_treatment_fnc_onMedicationUsage, that data is now fetched internally.
    • medical_status_fnc_getMedicationCount now returns an [num,num] array instead of a single num, so we have to select the desired element from the array.

@MiszczuZPolski
Copy link
Collaborator

Probably should be added in #675 , will review it tomorrow

@Cplhardcore
Copy link
Contributor

Im reworking how medications are checked in #675, by using getAllMedicationsCount instead

@mrschick
Copy link
Contributor Author

mrschick commented Jan 1, 2025

Yeah, my bad, only noticed that PR afterwards. This is just redundant.

@mrschick mrschick closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants