-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/에러 메세지 상수화 #846 #855
Merged
The head ref may contain hidden characters: "feature/\uC5D0\uB7EC_\uBA54\uC138\uC9C0_\uC0C1\uC218\uD654_#846"
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9847b69
refactor : api 관련 error/success 메시지 변수화
mun-kyeong d3fcba8
refactor : import 위치변경 및 PR반영
mun-kyeong 9772c16
refactor : mismatchPassword to mismatch
mun-kyeong 396f7b0
refactor : 백틱이 사용되는 부분 as const 선언
mun-kyeong 3d35fd6
refactor : 변수명 변경
mun-kyeong fdc445e
refactor : 변수명 변경 및 PR 반영
mun-kyeong cabcb44
confilct : 충돌해결
mun-kyeong 80da6c5
confilct : 충돌해결
mun-kyeong daab57e
confilct : 충돌해결
mun-kyeong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
export const COMMON = {} as const; | ||
|
||
export const PASSWORD = { | ||
success: { | ||
changed: '비밀번호가 변경되었습니다.', | ||
}, | ||
error: { | ||
mismatch: '현재 비밀번호가 일치하지 않습니다.', | ||
}, | ||
} as const; | ||
|
||
export const POST = { | ||
success: {}, | ||
error: { | ||
readCondition: '게시글 열람 조건을 충족하지 않습니다.', | ||
passwordMismatch: '게시글의 비밀번호가 일치하지 않습니다.', | ||
commentRequired: '댓글 작성이 필요합니다.', | ||
}, | ||
} as const; | ||
|
||
export const SEMINAR = { | ||
success: {}, | ||
error: { | ||
duplicateSeminarDate: '동일한 날짜의 세미나는 생성할 수 없습니다.', | ||
}, | ||
} as const; | ||
|
||
export const EMAIL = { | ||
success: { | ||
changed: '이메일 변경 성공하였습니다.', | ||
}, | ||
error: { | ||
existingEmail: '이미 존재하는 이메일입니다.', | ||
}, | ||
} as const; | ||
|
||
export const MEMBER_CARD = { | ||
success: {}, | ||
error: { | ||
noSubmissionsLeft: '남은 제출 횟수가 없습니다.', | ||
invalidAttendanceWithCount: (min: number) => `출석코드가 틀렸습니다. (남은 제출횟수 ${min}회)`, | ||
}, | ||
} as const; | ||
|
||
export const ID = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. API와 용어를 맞추기 위해 LOGIN_ID도 괜찮아 보입니다. |
||
success: {}, | ||
error: { | ||
existingId: '이미 존재하는 아이디입니다.', | ||
}, | ||
}; | ||
|
||
export const STUDENT_ID = { | ||
success: {}, | ||
error: { | ||
existingStudentId: '이미 존재하는 학번입니다.', | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
큰 상관은 없을 듯 하긴 한데 POST 대신 BOARD는 어떨까요...?
REST API의 POST랑 용어가 겹쳐보입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오옹 저도 REST API의 POST가 살짝 떠올랐었는데..! ㅎㅎ