Add TransferWindowPlanner - Fork #9049
Conversation
I forked TWP to make it useful for transfers between planets that have non-zero inclination (by specifying which inclined parking orbit should be used). This is especially important in RSS, but also in stock it can reduce Δv requirements by several hundred m/s for some transfers. In the process, I updated it for 1.12. It would be great to have on CKAN for easier installation, but I want it clear to users that it is a fork and not the original mod by TriggerAu.
|
Hi @Nazfib, thanks for the submission! I had a question and a suggestion regarding adopting this mod...
Otherwise this looks fine, but I'll hold off on merging for now in case we want to make changes regarding the above points. |
|
Hi, As for a thread on the forums, I'm not active there, so I'm likely to not see any responses. This basically started when I saw many people having trouble with interplanetary transfers on the KSP-RO discord, and I knew how to change TWP to make it easier, and it all snowballed a bit from there... any possible support I could give will have to happen there or in the issues on GitHub I'm afraid. |
|
Ahh, OK. What do you think about setting the |
|
Looks good to me, thanks for the submission! |
|
Hey both, You only have to reach out and I am around. I have been struggling with time between KSP2 and my other job, but have been trying to keep on top of things yeah. Didn't notice any questions from Nathan, nor PRs against TWP except yalovs one that I need to get in. Did I miss a PR somewhere? |
|
Kk, seeing the note about comms in the source patch, interesting I dont have a recent message from Nathan. I dont see any issues with the fork being diffn, etc, but also haven't seen any PR requests for this to the upstream repo yet. Ill have a dig around on the weekend and see if anything stands out. |
|
@TriggerAu That's super weird, The forum claims the PM I sent back in Feb was sent so I'm not sure what's going on. :( As to PRs, I added this ( TriggerAu/TransferWindowPlanner#60 ) back in October when I PM'd you then (and you responded), but no action occurred and I didn't hear back when I responded to that thread in Feb, thus I figured you were gone (or KSP2'd) for good. Glad to see you are around though! And sorry for the confusion. |
|
Here's the text of the forum PM (with your last reply from Oct) in case the forum ate it. TriggerAu Cool. Ill check it out Quote Hi! Hope things are well with you!! Just checking in--do you care if the RSS/RO optimized version of TWP gets put on CKAN? That will also give us a 1.10+ compatible version we can rec (for RO users) on CKAN, since your TWP is version-locked to 1.7. (It would be named to be clear it's a fork.) And as for KAC--I updated my PR to support 1.12 as well. KAC is such a great mod, it'd be really nice if it was installable through CKAN again! :) |
|
I got all me bits and bobs sorted, so v 1.8.0.0 shoudl update next time CKAN does a scan etc. im not 100% how this is expected to show up in CKAN - can check tomorrow Im sure :) . Will it show up as "TWP" and "TWP-RO Fork" or its expected to have some mechanism whereby it only presents to people with RO installed or some such? |
|
Yay!
I am on vacation ATM but I believe both will show? We can make the fork
depend on e.g. RSS but it's possible other planetary system mods may prefer
the fork too if they deal with inclinations? I don't know the current state
of play outside RO-land.
Sent by my thumbs, slowly.
…On Sun, Apr 10, 2022, 10:24 PM TriggerAu ***@***.***> wrote:
I got all me bits and bobs sorted, so v 1.8.0.0 shoudl update next time
CKAN does a scan etc.
im not 100% how this is expected to show up in CKAN - can check tomorrow
Im sure :) . Will it show up as "TWP" and "TWP-RO Fork" or its expected to
have some mechanism whereby it only presents to people with RO installed or
some such?
—
Reply to this email directly, view it on GitHub
<#9049 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHH4IV4MIAJTS4TAFIWM4TVEPOT7ANCNFSM5RYY2HNQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Maybe it some detail in the description so its a it clear its not two copies, or whats diffn or something. People done good work to create the fork, people should use it if they need it more than just pick the default one |
|
The new fork has "Fork" in the name and an extra author:
@Nazfib, you can differentiate the descriptions by editing this section of your repo on GitHub:
|
I forked TWP to make it useful for transfers between planets that have non-zero inclination (by specifying which inclined parking orbit should be used). This is especially important in RSS, but also in stock it can reduce Δv requirements by several hundred m/s for some transfers.
In the process, I updated it for 1.12.
It would be great to have on CKAN for easier installation, but I want it clear to users that it is a fork and not the original mod by TriggerAu.
Relates to Nazfib/TransferWindowPlanner#1.
https://github.com/Nazfib/TransferWindowPlanner