Fix a FIVE AND A HALF YEAR OLD BUG where Proc Parts didn't detect MFT…

… right.
KSP-RO · Oct 10, 2023 · 9f83e62 · 9f83e62
1 parent 4ae92f5
commit 9f83e62
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/Source/ProceduralPart.cs b/Source/ProceduralPart.cs
@@ -514,15 +514,16 @@ private void ChangeShape(ProceduralAbstractShape fromShape)
         [KSPField]
         public bool displayCost = true;
 
+        private bool? _hasMFT = null;
+
 		public ModifierChangeWhen GetModuleCostChangeWhen () => ModifierChangeWhen.FIXED;
 
         private bool ContainsMFT(Part p)
         {
-            foreach (PartModule pm in p.Modules)
-            {
-                if (pm.name.Equals("ModuleFuelTanks")) return true;
-            }
-            return false;
+            if (!_hasMFT.HasValue)
+                _hasMFT = part.Modules.Contains("ModuleFuelTanks");
+
+            return _hasMFT.Value;
         }
 
         private void GetResourceCosts(Part p, out float maxCost, out float actualCost)