Only initiate handshake if we know the current map #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only initiate the handshake if we can get the current map name.
zer0k-z
force-pushed
the
fix/handshake-shenanigans
branch
from
cbd415e to
2759f56
Compare
AlphaKeks
added a commit
to AlphaKeks/cs2kz-metamod
that referenced
this pull request
Feb 13, 2025
We should only initiate the handshake if we can get the current map name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in #290 that checks the handshake status before trying to get the current map name. If we can't get the current map name, we shouldn't try to initiate the handshake yet. The next time we change map and can get the name, we then handshake.
This PR depends on #291.