Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a connection name. #8

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

rubenv
Copy link
Contributor

@rubenv rubenv commented May 7, 2024

This can be helpful to identify specific connections in RabbitMQ, for debugging or tracing purposes.

I've matched the default values in amqp.Config (which are annoyingly not exposed in the lib itself), so behavior should be completely identical if this parameter is not set.

This can be helpful to identify specific connections in RabbitMQ, for
debugging or tracing purposes.
connection.go Outdated Show resolved Hide resolved
@m3talux
Copy link
Collaborator

m3talux commented May 7, 2024

I think this PR would be a good opportunity to initialize a CHANGELOG.md file, with the future 1.1.0 version. I could do it if you like.

@rubenv
Copy link
Contributor Author

rubenv commented May 7, 2024

Having a CHANGELOG would be good indeed!

I could do it if you like.

Yes, I'll leave that up to you so you can choose the style as you like.

@m3talux m3talux added the enhancement New feature or request label May 7, 2024
@m3talux m3talux merged commit c40e20b into KardinalAI:v1 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants