Skip to content

Polish Round 4

Polish Round 4 #544

Triggered via pull request November 12, 2023 12:56
Status Failure
Total duration 11m 32s
Artifacts 1
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

build-and-test.yml

on: pull_request
Build and Test PR
11m 19s
Build and Test PR
Fit to window
Zoom out
Zoom in

Annotations

1 error and 11 warnings
Build and Test PR
Process completed with exit code 1.
Build and Test PR
The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128
Build and Test PR: Kavita.Common/Configuration.cs#L20
Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
Build and Test PR: Kavita.Common/Configuration.cs#L20
Change the visibility of 'KavitaPlusApiUrl' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223)
Build and Test PR: Kavita.Common/Configuration.cs#L20
Refactor your code not to use hardcoded absolute paths or URIs. (https://rules.sonarsource.com/csharp/RSPEC-1075)
Build and Test PR: Kavita.Common/Configuration.cs#L323
Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218)
Build and Test PR: Kavita.Common/Configuration.cs#L325
Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218)
Build and Test PR: Kavita.Common/Configuration.cs#L327
Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218)
Build and Test PR: Kavita.Common/EnvironmentInfo/IOsInfo.cs#L15
Initialize all 'static fields' inline and remove the 'static constructor'. (https://rules.sonarsource.com/csharp/RSPEC-3963)
Build and Test PR: Kavita.Common/Helpers/UntrustedCertClientFactory.cs#L10
Enable server certificate validation on this SSL/TLS connection (https://rules.sonarsource.com/csharp/RSPEC-4830)
Build and Test PR: API/Helpers/Builders/AppUserBuilder.cs#L14
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build and Test PR: API/Helpers/Builders/ChapterBuilder.cs#L15
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Artifacts

Produced during runtime
Name Size
csproj Expired
972 Bytes