Better handle special chapters not leaking encoding on chapter detail…

… page
Kareadita · Sep 20, 2024 · dc935ba · dc935ba
1 parent 7beeab2
commit dc935ba
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/API/Controllers/SettingsController.cs b/API/Controllers/SettingsController.cs
@@ -345,7 +345,7 @@ public async Task<ActionResult<ServerSettingDto>> UpdateSettings(ServerSettingDt
 
             if (updateBookmarks)
             {
-                BackgroundJob.Enqueue(() => UpdateBookmarkDirectory(originalBookmarkDirectory, bookmarkDirectory));
+                UpdateBookmarkDirectory(originalBookmarkDirectory, bookmarkDirectory);
             }
 
             if (updateSettingsDto.EnableFolderWatching)
@@ -371,8 +371,8 @@ public async Task<ActionResult<ServerSettingDto>> UpdateSettings(ServerSettingDt
         return Ok(updateSettingsDto);
     }
 
-    // Public for Hangfire
-    public void UpdateBookmarkDirectory(string originalBookmarkDirectory, string bookmarkDirectory)
+
+    private void UpdateBookmarkDirectory(string originalBookmarkDirectory, string bookmarkDirectory)
     {
         _directoryService.ExistOrCreate(bookmarkDirectory);
         _directoryService.CopyDirectoryToDirectory(originalBookmarkDirectory, bookmarkDirectory);

diff --git a/UI/Web/src/app/cards/entity-title/entity-title.component.html b/UI/Web/src/app/cards/entity-title/entity-title.component.html
@@ -33,12 +33,19 @@
     @case (LibraryType.Manga) {
       @if (titleName !== '' && prioritizeTitleName) {
         @if (isChapter && includeChapter) {
-          {{t('chapter') + ' '  + number + ' - ' }}
+          @if (number === LooseLeafOrSpecial) {
+            {{t('chapter') + ' - ' }}
+          } @else {
+            {{t('chapter') + ' '  + number + ' - ' }}
+          }
+
         }
         {{titleName}}
       } @else {
         @if (includeVolume && volumeTitle !== '') {
-          {{number !== LooseLeafOrSpecial ? (isChapter && includeVolume ? volumeTitle : '') : ''}}
+          @if (number !== LooseLeafOrSpecial && isChapter && includeVolume) {
+            {{volumeTitle}}
+          }
         }
 
         @if (number !== LooseLeafOrSpecial) {

diff --git a/UI/Web/src/app/cards/entity-title/entity-title.component.ts b/UI/Web/src/app/cards/entity-title/entity-title.component.ts
@@ -22,7 +22,6 @@ import {DefaultValuePipe} from "../../_pipes/default-value.pipe";
 })
 export class EntityTitleComponent implements OnInit {
 
-  protected readonly LooseLeafOrSpecialNumber = LooseLeafOrDefaultNumber;
   protected readonly LooseLeafOrSpecial = LooseLeafOrDefaultNumber + "";
   protected readonly LibraryType = LibraryType;
 
@@ -62,11 +61,6 @@ export class EntityTitleComponent implements OnInit {
       this.titleName = c.titleName || '';
       this.number = c.range;
 
-      // If loose leaf/special
-      if (this.number === this.LooseLeafOrSpecial) {
-
-      }
-
     } else {
       const v = this.utilityService.asVolume(this.entity);
       this.volumeTitle = v.name || '';