Skip calibration calculation for 'NO_CALIBRATION' mode #1225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I am using Devolo Connect (MT02650) thermostat recognized by BT as generic thermostat. As there is already a calibration running in Devolo HC gateway, I set BT to use CalibrationMode NO_CALIBRATION. This did not work at all and wrong values were set to the TRV (mainly as the TRV does not provide measured temperature).
However if CalibrationMode is set to NO_CALIBRATION, no calibration value shall be calculated and temperature set in BT should be applied as entered as target temperature (normal, eco or off temperature).
Changes:
Skip calibration calculation in trv.py for 'NO_CALIBRATION' mode and use target temperature instead.
Fixed if statement in controlling.py for target temperature setting
Related issue (check one):
Checklist (check one):
Test-Hardware list (for code changes)
HA Version: 2023.12.4
Zigbee2MQTT Version: -
TRV Hardware: Devolo Connect (MT02650)
New device mappings
climate.py