Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip calibration calculation for 'NO_CALIBRATION' mode #1225

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

bueeler
Copy link
Contributor

@bueeler bueeler commented Jan 3, 2024

Motivation:

I am using Devolo Connect (MT02650) thermostat recognized by BT as generic thermostat. As there is already a calibration running in Devolo HC gateway, I set BT to use CalibrationMode NO_CALIBRATION. This did not work at all and wrong values were set to the TRV (mainly as the TRV does not provide measured temperature).
However if CalibrationMode is set to NO_CALIBRATION, no calibration value shall be calculated and temperature set in BT should be applied as entered as target temperature (normal, eco or off temperature).

Changes:

Skip calibration calculation in trv.py for 'NO_CALIBRATION' mode and use target temperature instead.
Fixed if statement in controlling.py for target temperature setting

Related issue (check one):

  • fixes #
  • there is no related issue ticket

Checklist (check one):

  • I did not change any code (e.g. documentation changes)
  • The code change is tested and works locally.

Test-Hardware list (for code changes)

HA Version: 2023.12.4
Zigbee2MQTT Version: -
TRV Hardware: Devolo Connect (MT02650)

New device mappings

  • I avoided any changes to other device mappings
  • There are no changes in climate.py

If CalibrationMode is NO_CALIBRATION, then no calibration value shall be calculated. But still it must be possible to change target temp for eco or off mode.
@KartoffelToby KartoffelToby merged commit b4e8bc1 into KartoffelToby:master Jan 4, 2024
2 of 3 checks passed
@bueeler bueeler mentioned this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants