Fix device_model parsing for multiple braces #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only get last value in braces. model description can also contain braces. Example Bosch: Room thermostat II (Battery model) (BTH-RM)
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only get last value in braces.
model description can also contain braces. Example Bosch: Room thermostat II (Battery model) (BTH-RM)
Motivation:
Devices can have multiple braces due to vendor having something like (Battery model) appended. See device info in comment: #1422 (comment)
Changes:
Fix regexp to extract value within last braces and return that value.
Related issue (check one):
Checklist (check one):
Test-Hardware list (for code changes)
HA Version: 2024.11.0
Zigbee2MQTT Version: 1.41.0
TRV Hardware: Bosch Room Thermostat II