Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Eurotronic Spirit Z-Wave valve #1547

Closed
wants to merge 1 commit into from

Conversation

Petititi
Copy link

@Petititi Petititi commented Jan 3, 2025

Motivation:

For zwave_js, entity.unique_id is named differently: it is "XXXX-38-0-currentValue".
An other PR will come that add a adapters/zwave_js.py to fully support those devices.

Changes:

Add "38-0-currentValue" pattern for valve detection

Related issue (check one):

  • fixes #
  • There is no related issue ticket

Checklist (check one):

  • I did not change any code (e.g. documentation changes)
  • [X ] The code change is tested and works locally.

Test-Hardware list (for code changes)

HA Version: Core 2024.12.5
Zigbee2MQTT Version: X
TRV Hardware: zwave_js

…amed differently: entity.unique_id is "XXXX-38-0-currentValue"
@Petititi
Copy link
Author

Petititi commented Jan 3, 2025

I just see the PR #1048 which is a step ahead of mine ! I'll decline my PR and try the other branch 🤞

@Petititi Petititi closed this Jan 3, 2025
@folfy
Copy link
Collaborator

folfy commented Jan 8, 2025

So the or entity.original_name == "Valve control" there works as well for you?

@Petititi
Copy link
Author

Petititi commented Jan 8, 2025

Unfortunatly not :-(
Mine is "Current value" (what a strange wording choice?!?) but I can't be sure that 38-0-currentValue will works well for alucryd
So I changed the way I will control my Spirits: I will do all the work with python scripts (pyscript) because I want to also control the water temperature of my heat-pump...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants