Fixes #38040 - Clear retain_version_count when mirroring policy is not additive #1954
sjha4ruby.yml
on: pull_request
Rubocop
/
Rubocop
1m 3s
Matrix: angular
Matrix: Ruby / existing-database
Matrix: Ruby / test
Ruby
/
Test suite
2s
Annotations
19 errors and 8 warnings
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13:
katello/test/controllers/api/v2/repositories_controller_test.rb#L567
Failure: test_update_with_cert
Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
Response body: {"displayMessage":"Fatal Error: See logs for details or contact system administrator","errors":["--- expected\n+++ actual\n@@ -1 +1 @@\n-{\"ssl_ca_cert_id\"=\u003e\"60750479\"}\n+{\"ssl_ca_cert_id\"=\u003e\"60750479\", \"retain_package_versions_count\"=\u003enil}\n"]}
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13:
katello/test/controllers/api/v2/repositories_controller_test.rb#L658
Failure: test_update_with_retain_package_versions_count
not all expectations were satisfied
unsatisfied expectations:
- expected exactly once, invoked never: #<Katello::Api::V2::RepositoriesController:0x12dce8>.sync_task(arguments_accepted_by_custom_matching_block)
satisfied expectations:
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getaddresses(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getaddress(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getnames(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getname(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Katello::Pulp3::Repository>.test_remote_name(any_parameters)
- allowed any number of times, invoked never: Katello::Ping.ping(any_parameters)
- allowed any number of times, invoked never: Cert::Certs.ssl_client_key(any_parameters)
- allowed any number of times, invoked never: Cert::Certs.ssl_client_cert(any_parameters)
- allowed any number of times, invoked never: Cert::Certs.ca_cert(any_parameters)
- allowed any number of times, invoked never: #<Katello::Api::V2::RepositoriesController:0x12dce8>.require_org(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Katello::Product(id: integer, name: string, description: text, cp_id: string, multiplier: integer, provider_id: integer, created_at: datetime, updated_at: datetime, gpg_key_id: integer, sync_plan_id: integer, label: string, organization_id: integer, ssl_ca_cert_id: integer, ssl_client_cert_id: integer, ssl_client_key_id: integer)>.key(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Katello::Product(id: integer, name: string, description: text, cp_id: string, multiplier: integer, provider_id: integer, created_at: datetime, updated_at: datetime, gpg_key_id: integer, sync_plan_id: integer, label: string, organization_id: integer, ssl_ca_cert_id: integer, ssl_client_cert_id: integer, ssl_client_key_id: integer)>.certificate(any_parameters)
- allowed any number of times, invoked never: Katello::Resources::CDN::CdnResource.ca_file_contents(any_parameters)
- allowed any number of times, invoked never: SmartProxy(id: integer, name: string, url: string, created_at: datetime, updated_at: datetime, pubkey: text, expired_logs: string, puppet_path: text, download_policy: string, http_proxy_id: integer, content_counts: jsonb).pulp_primary(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.output(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.cli_example(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.humanized(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.input(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.progress(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.result(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.state(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.ended_at(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.started_at(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.username(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.resumable?(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.execution_plan(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.pending(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.label(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.id(any_parameters)
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13:
katello/test/controllers/api/v2/repositories_controller_test.rb#L684
Failure: test_update_non_docker_repo_with_limit_tags
Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
Response body: {"displayMessage":"Fatal Error: See logs for details or contact system administrator","errors":["--- expected\n+++ actual\n@@ -1 +1 @@\n-{\"name\"=\u003e\"new name\"}\n+{\"name\"=\u003e\"new name\", \"retain_package_versions_count\"=\u003enil}\n"]}
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13:
katello/test/controllers/api/v2/repositories_controller_test.rb#L555
Failure: test_update_with_gpg_key
Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
Response body: {"displayMessage":"Fatal Error: See logs for details or contact system administrator","errors":["--- expected\n+++ actual\n@@ -1 +1 @@\n-{\"gpg_key_id\"=\u003e\"591165711\"}\n+{\"gpg_key_id\"=\u003e\"591165711\", \"retain_package_versions_count\"=\u003enil}\n"]}
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13:
katello/test/models/root_repository_test.rb#L585
Failure: test_yum_retain_package_versions_count
Expected false to be truthy.
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13:
katello/test/models/root_repository_test.rb#L63
Failure: test_invalid_retain_package_version_counts
--- expected
+++ actual
@@ -1 +1 @@
-["cannot be set for repos without 'Additive' mirroring policy.", "must not be a negative value."]
+["must not be a negative value."]
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13:
katello/test/models/root_repository_test.rb#L70
Failure: test_valid_retain_package_version_counts
#<Katello::RootRepository id: nil, name: "Repo 68", created_at: nil, updated_at: nil, major: nil, minor: nil, gpg_key_id: nil, content_id: "71", arch: "noarch", label: "repo_68", url: "http://inecas.fedorapeople.org/fakerepos/zoo2/", unprotected: false, content_type: "yum", product_id: 785257261, checksum_type: nil, pulp_scratchpad_checksum_type: nil, docker_upstream_name: nil, download_policy: "on_demand", verify_ssl_on_sync: true, upstream_username: nil, upstream_password: nil, deb_releases: nil, deb_components: nil, deb_architectures: nil, ssl_ca_cert_id: nil, ssl_client_cert_id: nil, ssl_client_key_id: nil, ignorable_content: nil, include_tags: nil, description: nil, ansible_collection_requirements: nil, http_proxy_policy: "none", http_proxy_id: nil, download_concurrency: nil, os_versions: nil, ansible_collection_auth_url: nil, ansible_collection_auth_token: nil, retain_package_versions_count: 2, generic_remote_options: nil, upstream_authentication_token: nil, mirroring_policy: "mirror_content_only", exclude_tags: nil, metadata_expire: nil, is_container_push: false, container_push_name: nil, container_push_name_format: nil, sync_dependencies: true> errors: Retain package versions count cannot be set for repos without 'Additive' mirroring policy.
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13:
katello/test/actions/katello/repository_test.rb#L37
Failure: test_0002_plans pulp3 update when retain_package_version is updated
ActiveRecord::RecordInvalid: Validation failed: Retain package versions count cannot be set for repos without 'Additive' mirroring policy.
katello/app/lib/actions/katello/repository/update.rb:19:in `plan'
katello/test/actions/katello/repository_test.rb:148:in `block in <class:UpdateTest>'
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13
Process completed with exit code 1.
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13:
katello/test/actions/katello/repository_test.rb#L37
Failure: test_0002_plans pulp3 update when retain_package_version is updated
ActiveRecord::RecordInvalid: Validation failed: Retain package versions count cannot be set for repos without 'Additive' mirroring policy.
katello/app/lib/actions/katello/repository/update.rb:19:in `plan'
katello/test/actions/katello/repository_test.rb:148:in `block in <class:UpdateTest>'
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13:
katello/test/controllers/api/v2/repositories_controller_test.rb#L567
Failure: test_update_with_cert
Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
Response body: {"displayMessage":"Fatal Error: See logs for details or contact system administrator","errors":["--- expected\n+++ actual\n@@ -1 +1 @@\n-{\"ssl_ca_cert_id\"=\u003e\"60750479\"}\n+{\"ssl_ca_cert_id\"=\u003e\"60750479\", \"retain_package_versions_count\"=\u003enil}\n"]}
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13:
katello/test/controllers/api/v2/repositories_controller_test.rb#L555
Failure: test_update_with_gpg_key
Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
Response body: {"displayMessage":"Fatal Error: See logs for details or contact system administrator","errors":["--- expected\n+++ actual\n@@ -1 +1 @@\n-{\"gpg_key_id\"=\u003e\"591165711\"}\n+{\"gpg_key_id\"=\u003e\"591165711\", \"retain_package_versions_count\"=\u003enil}\n"]}
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13:
katello/test/controllers/api/v2/repositories_controller_test.rb#L658
Failure: test_update_with_retain_package_versions_count
not all expectations were satisfied
unsatisfied expectations:
- expected exactly once, invoked never: #<Katello::Api::V2::RepositoriesController:0x74a608>.sync_task(arguments_accepted_by_custom_matching_block)
satisfied expectations:
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getaddresses(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getaddress(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getnames(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getname(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Katello::Pulp3::Repository>.test_remote_name(any_parameters)
- allowed any number of times, invoked never: Katello::Ping.ping(any_parameters)
- allowed any number of times, invoked never: Cert::Certs.ssl_client_key(any_parameters)
- allowed any number of times, invoked never: Cert::Certs.ssl_client_cert(any_parameters)
- allowed any number of times, invoked never: Cert::Certs.ca_cert(any_parameters)
- allowed any number of times, invoked never: #<Katello::Api::V2::RepositoriesController:0x74a608>.require_org(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Katello::Product(id: integer, name: string, description: text, cp_id: string, multiplier: integer, provider_id: integer, created_at: datetime, updated_at: datetime, gpg_key_id: integer, sync_plan_id: integer, label: string, organization_id: integer, ssl_ca_cert_id: integer, ssl_client_cert_id: integer, ssl_client_key_id: integer)>.key(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Katello::Product(id: integer, name: string, description: text, cp_id: string, multiplier: integer, provider_id: integer, created_at: datetime, updated_at: datetime, gpg_key_id: integer, sync_plan_id: integer, label: string, organization_id: integer, ssl_ca_cert_id: integer, ssl_client_cert_id: integer, ssl_client_key_id: integer)>.certificate(any_parameters)
- allowed any number of times, invoked never: Katello::Resources::CDN::CdnResource.ca_file_contents(any_parameters)
- allowed any number of times, invoked never: SmartProxy(id: integer, name: string, url: string, created_at: datetime, updated_at: datetime, pubkey: text, expired_logs: string, puppet_path: text, download_policy: string, http_proxy_id: integer, content_counts: jsonb).pulp_primary(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.output(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.cli_example(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.humanized(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.input(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.progress(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.result(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.state(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.ended_at(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.started_at(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.username(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.resumable?(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.execution_plan(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.pending(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.label(any_parameters)
- allowed any number of times, invoked never: #<Mock:task>.id(any_parameters)
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13:
katello/test/controllers/api/v2/repositories_controller_test.rb#L684
Failure: test_update_non_docker_repo_with_limit_tags
Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
Response body: {"displayMessage":"Fatal Error: See logs for details or contact system administrator","errors":["--- expected\n+++ actual\n@@ -1 +1 @@\n-{\"name\"=\u003e\"new name\"}\n+{\"name\"=\u003e\"new name\", \"retain_package_versions_count\"=\u003enil}\n"]}
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13:
katello/test/models/root_repository_test.rb#L63
Failure: test_invalid_retain_package_version_counts
--- expected
+++ actual
@@ -1 +1 @@
-["cannot be set for repos without 'Additive' mirroring policy.", "must not be a negative value."]
+["must not be a negative value."]
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13:
katello/test/models/root_repository_test.rb#L70
Failure: test_valid_retain_package_version_counts
#<Katello::RootRepository id: nil, name: "Repo 80", created_at: nil, updated_at: nil, major: nil, minor: nil, gpg_key_id: nil, content_id: "77", arch: "noarch", label: "repo_80", url: "http://inecas.fedorapeople.org/fakerepos/zoo2/", unprotected: false, content_type: "yum", product_id: 785257261, checksum_type: nil, pulp_scratchpad_checksum_type: nil, docker_upstream_name: nil, download_policy: "on_demand", verify_ssl_on_sync: true, upstream_username: nil, upstream_password: nil, deb_releases: nil, deb_components: nil, deb_architectures: nil, ssl_ca_cert_id: nil, ssl_client_cert_id: nil, ssl_client_key_id: nil, ignorable_content: nil, include_tags: nil, description: nil, ansible_collection_requirements: nil, http_proxy_policy: "none", http_proxy_id: nil, download_concurrency: nil, os_versions: nil, ansible_collection_auth_url: nil, ansible_collection_auth_token: nil, retain_package_versions_count: 2, generic_remote_options: nil, upstream_authentication_token: nil, mirroring_policy: "mirror_content_only", exclude_tags: nil, metadata_expire: nil, is_container_push: false, container_push_name: nil, container_push_name_format: nil, sync_dependencies: true> errors: Retain package versions count cannot be set for repos without 'Additive' mirroring policy.
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13:
katello/test/models/root_repository_test.rb#L585
Failure: test_yum_retain_package_versions_count
Expected false to be truthy.
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13
Process completed with exit code 1.
|
|
Ruby / Test suite
Process completed with exit code 1.
|
|
Rubocop / Rubocop
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Ruby / Setup matrix
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Ruby / db:seed - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Ruby / db:seed - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Ruby / plugin:assets:precompile[katello] RAILS_ENV=production DATABASE_URL=nulldb://nohost - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Ruby / plugin:assets:precompile[katello] RAILS_ENV=production DATABASE_URL=nulldb://nohost - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Ruby / test:katello - Foreman develop with Ruby 2.7 and Node 18 on PostgreSQL 13
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Ruby / test:katello - Foreman develop with Ruby 3.0 and Node 18 on PostgreSQL 13
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
Gemfile-ruby-27-node-18-pg-13-foreman-develop-dbseed.lock
|
5.47 KB |
|
|
Gemfile-ruby-27-node-18-pg-13-foreman-develop-pluginassetsprecompilekatelloRAILSENVproductionDATABASEURLnulldbnohost.lock
|
5.47 KB |
|
|
Gemfile-ruby-27-node-18-pg-13-foreman-develop-testkatello.lock
|
5.47 KB |
|
|
Gemfile-ruby-30-node-18-pg-13-foreman-develop-dbseed.lock
|
5.49 KB |
|
|
Gemfile-ruby-30-node-18-pg-13-foreman-develop-pluginassetsprecompilekatelloRAILSENVproductionDATABASEURLnulldbnohost.lock
|
5.49 KB |
|
|
Gemfile-ruby-30-node-18-pg-13-foreman-develop-testkatello.lock
|
5.49 KB |
|
|
Gemfile-theforeman-actions-rubocop-ruby-2.7.lock
|
2.95 KB |
|
|
all_react_app_exports-ruby-27-node-18-pg-13-foreman-develop-testkatello.js
|
8.1 KB |
|
|
all_react_app_exports-ruby-30-node-18-pg-13-foreman-develop-testkatello.js
|
8.1 KB |
|
|
logs-ruby-27-node-18-pg-13-foreman-develop-testkatello
Expired
|
4.04 MB |
|
|
logs-ruby-30-node-18-pg-13-foreman-develop-testkatello
Expired
|
4.04 MB |
|
|
package-lock-ruby-27-node-18-pg-13-foreman-develop-pluginassetsprecompilekatelloRAILSENVproductionDATABASEURLnulldbnohost.json
|
324 KB |
|
|
package-lock-ruby-27-node-18-pg-13-foreman-develop-testkatello.json
|
324 KB |
|
|
package-lock-ruby-30-node-18-pg-13-foreman-develop-pluginassetsprecompilekatelloRAILSENVproductionDATABASEURLnulldbnohost.json
|
324 KB |
|
|
package-lock-ruby-30-node-18-pg-13-foreman-develop-testkatello.json
|
324 KB |
|