Fixes #38158 - restrict repositories to RHEL 10 #11286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
reviewed
Jan 22, 2025
| @@ -39,7 +39,8 @@ class RootRepository < Katello::Model | |||
| RHEL7 = 'rhel-7'.freeze | |||
| RHEL8 = 'rhel-8'.freeze | |||
| RHEL9 = 'rhel-9'.freeze | |||
| ALLOWED_OS_VERSIONS = [RHEL6, RHEL7, RHEL8, RHEL9].freeze | |||
| RHEL10 = 'rhel-10'.freeze | |||
There was a problem hiding this comment.
Is this the tag that will be provided by the RHEL10 installed product? (I mean, it probably is, but it would be nice to confirm. It's certainly possible it can't be confirmed until after RHEL10 GA)
There was a problem hiding this comment.
Where does this tag come from for RH repos? Is it the manifest?
There was a problem hiding this comment.
The product cert:
# rct cat-cert /etc/pki/product-default/479.pem
+-------------------------------------------+
Product Certificate
+-------------------------------------------+
Certificate:
Path: /etc/pki/product-default/479.pem
Version: 1.0
Serial: 12750047592154747873
Start Date: 2024-01-16 15:30:21+00:00
End Date: 2044-01-16 15:30:21+00:00
Subject:
CN: Red Hat Product ID [3ad649c5-c93c-4662-ab13-b71883f5ef72]
Issuer:
C: US
CN: Red Hat Entitlement Product Authority
O: Red Hat, Inc.
OU: Red Hat Network
ST: North Carolina
emailAddress: [email protected]
Product:
ID: 479
Name: Red Hat Enterprise Linux for x86_64
Version: 9.5
Arch: x86_64
Tags: rhel-9,rhel-9-x86_64
Brand Type:
Brand Name:
sjha4
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Able to see rhel 10 as valid restrict to OS option. 🍏
Rhel9 doesn't get the repositories when restricting to rhel10,: 🍏
Rhel10 gets the repository 🍏
Rhel10 does not get repository when repo restricted to rhel9 🍏
Rhel9 gets repository when repo restricted to rhel9 🍏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds RHEL 10 to the OS restriction list for repos.
Considerations taken when implementing this change?
Inspiration: #9786
We need to come up with a way to catch this since it'll be likely forgotten each RHEL release.
What are the testing steps for this pull request?