Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #38162 - Fix invalid self-closing tags #11292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Jan 28, 2025

What are the changes introduced in this pull request?

Add closing tag for <select>, <div>, <span> and some bastion <date> tags

Considerations taken when implementing this change?

Some browsers are smart and display invalid HTML correctly. Not all invalid self closing tags were causing issues for me on the UI in chrome. Others like select and textarea were.

What are the testing steps for this pull request?

  1. Go to Products > Repo discovery and make sure the form renders correctly.
  2. Scan a URL for repos, ex: https://jlsherrill.fedorapeople.org/fake-repos/
  3. Create a repository out of a discovered repo and make sure the form looks ok in the create page.

@sjha4 sjha4 force-pushed the repo_discovery_form branch from 5df0556 to f819414 Compare January 28, 2025 16:06
@sjha4 sjha4 changed the title Refs #38162 - Fix repo discovery form Refs #38162 - Fix invalid self-closing tags Jan 29, 2025
@sjha4 sjha4 requested a review from chris1984 January 29, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant