Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof reordering (WIP) #3141

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented May 15, 2023

Experiment to logically group steps in proof.

Two main features:

  • "Reorder" proof steps such that adjacent proof steps modify the same formula (no interweaving of two simplification chains)
  • "Regroup" proof steps in the proof tree view (UI only)

TODOs

  • Handle pruning correctly after regrouping
  • Tests
  • Documentation

The order of proof steps is determined as follows:

  1. Steps with no inputs (no find / assumes)
  2. Steps ordered by the dep. graph data
  3. (optional) Step with no input that splits (e.g. sign_case_distinction)

To order the steps based on the dependency graph a queue of "available" graph nodes is managed. This queue is repeatedly iterated through to check for edges (steps) that are applicable. If they aren't the node is added to the end of the queue again. (More details will follow soon™)

@github-actions
Copy link

github-actions bot commented May 15, 2023

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Attention: Patch coverage is 12.13675% with 514 lines in your changes are missing coverage. Please review.

Project coverage is 37.86%. Comparing base (9ad6cc8) to head (3107e20).

❗ Current head 3107e20 differs from pull request most recent head 7246b1e. Consider uploading reports for the commit 7246b1e to get more accurate results

Files Patch % Lines
...ain/java/org/key_project/slicing/ProofReorder.java 0.00% 98 Missing ⚠️
..._project/slicing/ProofRegroupSettingsProvider.java 0.00% 76 Missing ⚠️
...java/org/key_project/slicing/RegroupExtension.java 0.00% 61 Missing ⚠️
...ain/java/org/key_project/slicing/ProofRegroup.java 0.00% 58 Missing ⚠️
.../org/key_project/slicing/ProofRegroupSettings.java 0.00% 52 Missing ⚠️
...ava/org/key_project/slicing/graph/DotExporter.java 0.00% 29 Missing ⚠️
...va/org/key_project/slicing/ReorderingReplayer.java 0.00% 27 Missing ⚠️
...org/key_project/util/collection/ImmutableList.java 0.00% 24 Missing ⚠️
...ava/org/key_project/util/collection/GraphUtil.java 0.00% 18 Missing ⚠️
...core/src/main/java/de/uka/ilkd/key/proof/Node.java 21.05% 15 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##               main    #3141     +/-   ##
===========================================
  Coverage     37.85%   37.86%             
+ Complexity    17042    16953     -89     
===========================================
  Files          2082     2063     -19     
  Lines        127290   126069   -1221     
  Branches      21441    21321    -120     
===========================================
- Hits          48183    47730    -453     
+ Misses        73194    72484    -710     
+ Partials       5913     5855     -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FliegendeWurst FliegendeWurst added this to the v2.14.0 milestone Jul 14, 2023
@FliegendeWurst FliegendeWurst added GUI Feature New feature or request labels Jul 22, 2023
@FliegendeWurst FliegendeWurst self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant