Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of bitwise operators #3172

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ChristianHein
Copy link
Contributor

@ChristianHein ChristianHein commented Jun 15, 2023

  • Adds missing taclets for intermediate JavaDL functions unsignedshiftrightJlong, xorJlong, orJlong, and andJlong. Without these, one cannot use the Java operators >>>, ^, |, and & with parameters of type long.
  • Fixes a bug in the taclets which pull a bitwise negation out of a modality, making them unusable. This was caused by a trivial mismatch between the program variables referenced in the taclets' \find and \replacewith statements. This bug was not present in 208396f.

@FliegendeWurst
Copy link
Member

You will need to update taclets.old.txt as described in TestTacletEquality.java.

@ChristianHein ChristianHein force-pushed the hein/bitwiseOperatorsTranslation branch from 7f11767 to 8b96b8a Compare June 15, 2023 13:12
Corrects mismatches between the program variables referenced in the
`\replacewith` and `\find` statements.

Unit tests were updated by repeating the same changes in
`taclets.old.txt`.
Some bitwise operations were missing translation taclets for the case
that the parameters are of type `long`. For example, `andJlong` did not
have a definition.
@ChristianHein ChristianHein force-pushed the hein/bitwiseOperatorsTranslation branch from 8b96b8a to 52d730d Compare June 15, 2023 13:18
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #3172 (727fbe5) into main (bf8cca5) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3172      +/-   ##
============================================
- Coverage     37.78%   37.78%   -0.01%     
  Complexity    16851    16851              
============================================
  Files          2052     2052              
  Lines        125409   125409              
  Branches      21220    21220              
============================================
- Hits          47386    47384       -2     
- Misses        72187    72189       +2     
  Partials       5836     5836              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

@WolframPfeifer WolframPfeifer self-requested a review June 19, 2023 15:22
@WolframPfeifer WolframPfeifer added this to the v2.12.0 milestone Jun 19, 2023
@wadoon wadoon removed this from the v2.12.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants