Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the broken automode #3533

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fixing the broken automode #3533

merged 2 commits into from
Dec 16, 2024

Conversation

mattulbrich
Copy link
Member

Intended Change

The auto-mode in KeY does no longer work: It merely loads a file but does not try to prove it.
This PR partially reverts changes introduced in 8b6df72.

Plan

  • Fix ConsoleUserInterfaceControl

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)

Ensuring quality

  • I have tested the feature as follows: Run it on the CLI

Additional information and contact(s)

It re-establishes CLI behaviour that we used to have in KeY.

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

partially reverting changes introduced in 8b6df72
Copy link
Member

@unp1 unp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks fine.
Only suggestion I would have (and that issue is not introduced by this PR): We could pull line 135 before the if statement and then remove line 145 completely and replace result2 by result.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.19%. Comparing base (3c41ebb) to head (db23498).
Report is 40 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3533      +/-   ##
============================================
+ Coverage     38.15%   38.19%   +0.03%     
- Complexity    17221    17228       +7     
============================================
  Files          2110     2111       +1     
  Lines        127630   127642      +12     
  Branches      21461    21463       +2     
============================================
+ Hits          48703    48750      +47     
+ Misses        72935    72903      -32     
+ Partials       5992     5989       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wadoon wadoon enabled auto-merge December 16, 2024 18:46
@wadoon wadoon added this pull request to the merge queue Dec 16, 2024
Merged via the queue into KeYProject:main with commit c39b255 Dec 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants