fix: small fixes

KevinBLT · Mar 17, 2024 · 2153f57 · 2153f57
1 parent 0ec2dbb
commit 2153f57
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 6 deletions.
diff --git a/packages/@hec.js/ui/lib/src/component.js b/packages/@hec.js/ui/lib/src/component.js
@@ -33,7 +33,7 @@ const attributeObserver = new MutationObserver((mutations) => {
  * @typedef { (name: string, props: T, fn: ComponentConstructor<T>) => void } UIElement
  */
 
-/** @type { UIElement<T> } */
+/** @type { UIElement<any> } */
 function UIElement(name, props, fn) {
 
   components.set(name, async (
@@ -121,11 +121,26 @@ function UIElement(name, props, fn) {
   emit('::component/' + name);
 }
 
-/** @type { UIElement<T> } */
+/**
+ * @template T
+ * @param { string } name 
+ * @param { T } props 
+ * @param { ComponentConstructor<T> } fn 
+ */
 export const component = (name, props, fn) => UIElement(`component/${ name }`, props, fn);
 
-/** @type { UIElement<T> } */
+/**
+ * @template T
+ * @param { string } name 
+ * @param { T } props 
+ * @param { ComponentConstructor<T> } fn 
+ */
 export const view = (name, props, fn) => UIElement(`view/${ name }`, props, fn);
 
-/** @type { UIElement<T> } */
+/**
+ * @template T
+ * @param { string } name 
+ * @param { T } props 
+ * @param { ComponentConstructor<T> } fn 
+ */
 export const page = (name, props, fn) => UIElement(`page/${ name }`, props, fn);
diff --git a/packages/@hec.js/ui/lib/src/notify.js b/packages/@hec.js/ui/lib/src/notify.js
@@ -20,7 +20,7 @@ const intersectionObserver = new IntersectionObserver((entries) => {
     }
   }
 }, {
-  rootMargin: '256px',
+  rootMargin: '512px',
 });
 
 new MutationObserver((mutations) => {

diff --git a/packages/@hec.js/ui/lib/src/signal.js b/packages/@hec.js/ui/lib/src/signal.js
@@ -112,7 +112,11 @@ export function signal(value = null, options = {}) {
     value = v;
 
     if (storage) {
-      storage.setItem(options.id, JSON.stringify(value));
+      if (v === null || v === undefined) {
+        storage.removeItem(options.id);
+      } else {
+        storage.setItem(options.id, JSON.stringify(value));
+      }
     }
 
     for (const subscriber of subscribers) {
-Original file line number
+Diff line change
@@ Expand Up @@
         }
       }
     }, {
-      rootMargin: '256px',
+      rootMargin: '512px',
     });
     new MutationObserver((mutations) => {
@@ Expand Down @@