fix: better queue of routing update

KevinBLT · Mar 9, 2024 · 5a53e43 · 5a53e43
1 parent a2becfb
commit 5a53e43
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/@hec.js/ui/lib/src/routing.js b/packages/@hec.js/ui/lib/src/routing.js
@@ -4,7 +4,8 @@ export const query = signal({});
 export const route = signal(location.pathname);
 
 const _pushState    = window.history.pushState,
-      _replaceState = window.history.replaceState;
+      _replaceState = window.history.replaceState,
+      state         = { updateQueued: false };
 
 /** 
  * @typedef {{  
@@ -60,6 +61,12 @@ export function addRoute(route) {
 
   targetRoutes.push(route);
   targetRoutes.sort(routeCompare);
+
+  if (state.updateQueued) {
+    state.updateQueued = true;
+
+    queueMicrotask(updateRouting);
+  }
 }
 
 export function navigate(path = '') {
@@ -106,6 +113,8 @@ export const updateRouting = () => {
     return hasFullMatch;
   }
 
+  state.updateQueued = false;
+
   return updateGroup(routes);
 }
 

diff --git a/packages/@hec.js/ui/lib/src/template.js b/packages/@hec.js/ui/lib/src/template.js
@@ -146,8 +146,6 @@ export function templateByNode(template, props = {}) {
 
   findExpression(template, new WeakSet());
 
-  queueMicrotask(updateRouting);
-
   return template;
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -146,8 +146,6 @@ export function templateByNode(template, props = {}) { @@
       findExpression(template, new WeakSet());
-      queueMicrotask(updateRouting);
       return template;
     }
@@ Expand Down @@