Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- #163

Closed
wants to merge 4 commits into from
Closed

- #163

wants to merge 4 commits into from

Conversation

riveronly
Copy link
Contributor

@riveronly riveronly commented May 25, 2024

@KevinnZou
Copy link
Owner

@riveronly Thanks for your contribution. I am currently traveling and will begin reviewing this PR next week. Thank you again!

@KevinnZou KevinnZou self-assigned this May 26, 2024
@KevinnZou KevinnZou added the enhancement New feature or request label May 26, 2024
@KevinnZou
Copy link
Owner

@msasikanth Could you also have a review on this PR? Thanks!

@riveronly riveronly closed this May 27, 2024
@riveronly riveronly changed the title fix(backgroundColor issue): ios add opaque params default true fix(backgroundColor issue): ios add opaque param May 27, 2024
@riveronly
Copy link
Contributor Author

@KevinnZou please delete this PR and I will resubmit it

@riveronly riveronly changed the title fix(backgroundColor issue): ios add opaque param - May 27, 2024
@riveronly
Copy link
Contributor Author

@KevinnZou I accidentally used the wrong email address to submit. Can you submit a work order to github to delete this mr? This is very important to me, thank you.

@msasikanth
Copy link
Contributor

msasikanth commented May 27, 2024

@KevinnZou I accidentally used the wrong email address to submit. Can you submit a work order to github to delete this mr? This is very important to me, thank you.

I don't think there is a way to delete the PR on GitHub. The only option is to close it and open a new one, if it has to be deleted it needs to be from GitHub support (which I don't think will happen in most scenarios).

@msasikanth
Copy link
Contributor

fwiw I see only the last commit in this PR has a different username. So, you can just drop that commit and force push to your repo. That should clear it.

@riveronly
Copy link
Contributor Author

Removing commit and force push will change the header information and it will not be the same merge request. Merge request records can be deleted only if github supports it. But there is no other way to delete this commit.

@KevinnZou
Copy link
Owner

@riveronly I found that you already submitted a new PR. We can directly review that one and dismiss this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants