Custom android chrome client (allowing for file selection) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @KevinnZou :) I took the liberty of expanding on @briandr97 's PR based on your comment to be able to open a file picker on Android.
Came up with this solution (generic but requiring empty actual classes for ios and desktop) since it's backwards compatible and imho less obfuscated than using a
LocalCompositionProviderthat would provide the webViewClient and chromeClient to theAccompanistWebView.Please let me know if you have a different approach in mind or feel free to do some changes to this PR in case it's not exactly to your liking :)