Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable popup windows on desktop #45

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Disable popup windows on desktop #45

merged 2 commits into from
Nov 24, 2023

Conversation

DatL4g
Copy link
Collaborator

@DatL4g DatL4g commented Nov 16, 2023

Popup windows can be enabled/disabled on desktop now, default is unchanged (enabled)

Copy link
Owner

@KevinnZou KevinnZou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions! Everything looks great. The only thing that needs to be changed is reformatting the code. I added a code check CI last week, which runs the ktlint check for each PR.

To fix the code, run the ktlintFormat task locally and submit it again. For easier management in the future, use the setUpGitHooks task to set up git hooks. This will automatically reformat the code whenever you commit.

@DatL4g
Copy link
Collaborator Author

DatL4g commented Nov 18, 2023

@KevinnZou
Please create a github action which has write permission on pull requests and runs the task instead.
I prevent GitHooks on my system for security reasons

@KevinnZou
Copy link
Owner

KevinnZou commented Nov 22, 2023

@KevinnZou Please create a github action which has write permission on pull requests and runs the task instead. I prevent GitHooks on my system for security reasons

@DatL4g I prefer not to grant write permission to GitHub Actions for some reason. If you don't want to use GitHooks, please run ktlintFormat on your local machine. Thank you for your contribution!

@KevinnZou KevinnZou merged commit f29c96f into KevinnZou:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants