change use_struct_references behaviour when it would generate invalid type #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for #342. More description and discussion in the issue itself.
I am definitely fine for going another approach (reason for draft) if the breaking change is not appropriate.
This PR fixes the issue by changing what type is generated for non-nullable input field types with no default value: for example the added test currently generates:
Previously, it would generate:
and after #338 this would cause an error during generation as the validation is trying to prevent a type that could cause runtime error by omitting a value for a type for which omitting is not possible.
I have: