[Interactive Graph] New Axes type for graph markings. #2053
Conversation
|
Size Change: +49 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
catandthemachines
changed the title
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (078eeee) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2053If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2053 |
catandthemachines
changed the title
catandthemachines
requested review from
nishasy,
jeremywiebe,
benchristel and
anakaren-rojas
| /** | ||
| * The type of markings to display on the graph. | ||
| * - axes: shows the axes without the gride lines | ||
| * - graph: shows the axes and the grid lines | ||
| * - grid: shows only the grid lines | ||
| * - none: shows no markings | ||
| */ |
There was a problem hiding this comment.
Since the possible values are not actually defined on this line anymore, it seems like this comment might drift out of sync with the code. How would you feel about documenting the different values where MarkingsType is defined (in perseus-types.ts)?
There was a problem hiding this comment.
The code looks good! I think we should probably have a visual test for the axes option, in interactive-graph-regression.stories.ts.
Writing that test will probably involve updating interactive-graph-question-builder.ts as well, which currently has hardcoded "grid" | "graph" | "none".
Summary:
At request from content creators they would like to have a new marking type for graph that will show the axes without requiring a full grid.
Issue: LEMS-2713
Test plan:
Go to: http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-linear or any other graph editor.
Select
Axesoption and notice new axes graph markings.