Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch 1 of simple default widget option transfers #2144

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jan 23, 2025

Summary:

I couldn't justify doing a PR per widget because all of these are really straight-forward; there's no prop upgrades or versions or anything. It's just moving "default props" from editors into "default widget options" in core so we can do minor upgrades on the server.

[LEMS-2737/default-collection] matcher
[LEMS-2737/default-collection] interaction
[LEMS-2737/default-collection] input-number
[LEMS-2737/default-collection] image
[LEMS-2737/default-collection] iframe
[LEMS-2737/default-collection] group
[LEMS-2737/default-collection] graded-group
[LEMS-2737/default-collection] explanation
[LEMS-2737/default-collection] dropdown
[LEMS-2737/default-collection] definition
[LEMS-2737/default-collection] cs-program
[LEMS-2737/default-collection] categorizer

Issue: LEMS-2737

Test plan:

Nothing should change, just moving code

@handeyeco handeyeco self-assigned this Jan 23, 2025
@handeyeco handeyeco changed the title [LEMS-2737/default-collection] graded-group-set Batch 1 of simple default widget option transfers Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (d86f5d3) and published it to npm. You
can install it using the tag PR2144.

Example:

yarn add @khanacademy/perseus@PR2144

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2144

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Size Change: +719 B (+0.05%)

Total Size: 1.48 MB

Filename Size Change
packages/perseus-core/dist/es/index.js 28.9 kB +1.02 kB (+3.67%)
packages/perseus-editor/dist/es/index.js 688 kB -304 B (-0.04%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 86.8 kB
packages/math-input/dist/es/index.js 77.6 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus-score/dist/es/index.js 113 kB
packages/perseus/dist/es/index.js 395 kB
packages/perseus/dist/es/strings.js 5.37 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@handeyeco handeyeco requested a review from a team January 23, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant