Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WB-1636: Announce popover contents correctly to screen readers #2134

Merged
merged 1 commit into from
Dec 5, 2023

Fix popover issues with screen readers

d17c268
Select commit
Loading
Failed to load commit list.
Merged

WB-1636: Announce popover contents correctly to screen readers #2134

Fix popover issues with screen readers
d17c268
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Dec 5, 2023 in 0s

97.05% (+0.00%) compared to 9092363

View this Pull Request on Codecov

97.05% (+0.00%) compared to 9092363

Details

Codecov Report

Merging #2134 (d17c268) into main (9092363) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2134   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files         241      241           
  Lines       28038    28055   +17     
  Branches     2464     2417   -47     
=======================================
+ Hits        27212    27229   +17     
  Misses        826      826           
Files Coverage Δ
...ks-popover/src/components/popover-content-core.tsx 100.00% <100.00%> (ø)
...-blocks-popover/src/components/popover-content.tsx 99.37% <100.00%> (+0.02%) ⬆️
...r-blocks-popover/src/components/popover-dialog.tsx 99.32% <100.00%> (+<0.01%) ⬆️
...s/wonder-blocks-popover/src/components/popover.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9092363...d17c268. Read the comment docs.