Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fei5403.1.workflowstonode20] Move workflows to node 20 #2144

Merged
merged 4 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/quiet-snakes-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
2 changes: 1 addition & 1 deletion .github/workflows/chromatic-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
# Map the job output to the workflow output.
outputs:
storybookUrl: ${{ steps.chromatic_publish.outputs.storybookUrl }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chromatic-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
steps:
# Create/update PR comment with Chromatic results
- name: Find existing comment
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Install & cache node_modules
uses: Khan/actions@shared-node-cache-v0
with:
node-version: 16.x
node-version: 20.x

- name: Build all packages
# Build all WB packages that Storybook depends on.
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/node-ci-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
steps:
- uses: actions/checkout@v2
- name: Install & cache node_modules
Expand All @@ -36,7 +36,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
shard: ["1/2", "2/2"]
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -166,7 +166,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -203,7 +203,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
steps:
# We need to checkout all history, so that the changeset tool can diff it
- name: Checkout current commit
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/node-ci-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# which is very helpful.
matrix:
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
steps:
- uses: actions/checkout@v2
- name: Install & cache node_modules
Expand All @@ -47,7 +47,7 @@ jobs:
# Use a matrix as it means we get the version info in the job name
# which is very helpful.
os: [ubuntu-latest]
node-version: [16.x]
node-version: [20.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Install & cache node_modules
uses: Khan/actions@shared-node-cache-v0
with:
node-version: 16.x
node-version: 20.x

- name: Create Release Pull Request or Publish to npm
id: changesets
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ describe("#getGqlDataFromReponse", () => {

// Assert
await expect(result).rejects.toThrowErrorMatchingInlineSnapshot(`
"Failed to parse response
caused by
SyntaxError: Unexpected token B in JSON at position 0"
`);
"Failed to parse response
caused by
SyntaxError: Unexpected token 'B', "BAD JSON" is not valid JSON"
`);
});

it("should include status code and body text in parse error metadata", async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ describe("RespondWith", () => {

// Assert
await expect(act).rejects.toThrowErrorMatchingInlineSnapshot(
`"invalid json response body at reason: Unexpected token I in JSON at position 0"`,
`"invalid json response body at reason: Unexpected token 'I', "INVALID JSON" is not valid JSON"`,
);
});

Expand Down
Loading