[🔥AUDIT🔥] WB-1645.fix Dropdown: Fix regression in SingleSelect #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 53c4f69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jandrade
requested review from
jeremyspangler,
nedredmond and
jeremywiebe
and removed request for
jeremyspangler
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2146 +/- ##
=======================================
Coverage 97.06% 97.06%
=======================================
Files 244 244
Lines 28256 28256
Branches 2461 2421 -40
=======================================
Hits 27428 27428
Misses 828 828
Continue to review full report in Codecov by Sentry.
|
|
Size Change: -6 B (0%) Total Size: 91.6 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (7c94d52) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2146"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2146 |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-tdlfyvvctz.chromatic.com/ Chromatic results:
|
jeremywiebe
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖍 This is an audit! 🖍
Summary:
Fixes a regression in
SingleSelectwhere the opener is not able to use anempty string as a label.
In #2139, I changed the logic to use
1 itemfor those cases, but turns outthat this "empty" value feature is required by Perseus.
Issue: WB-1645
Test plan:
Verify that the "Two with Text" example in the
SingleSelectstorybook pageshows empty string as the label for both openers:
http://localhost:6061/?path=/story/dropdown-singleselect--two-with-text