Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pill updates - updated colors, small pills are bigger for a11y #2154

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Pill updates - updated colors, small pills are bigger for a11y #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
926174e
Pill updates - updated colors, small pills are bigger for a11y
nishasy Dec 22, 2023
25dad90
Update documentation to explain the new kinds
nishasy Dec 22, 2023
fdaf3e4
Change pill colors to be faded16 colors
nishasy Jan 3, 2024
83437b3
Fix the color names in unit test
nishasy Jan 3, 2024
31ccbee
Update pill package config
nishasy Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/witty-crabs-clean.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@khanacademy/wonder-blocks-theming": minor
"@khanacademy/wonder-blocks-pill": minor
---

Added more colors to Pill, small pills are now 24px tall with 14px font size. Tokens (theming) now include pill colors.
14 changes: 12 additions & 2 deletions __docs__/wonder-blocks-pill/pill.argtypes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,22 @@ export default {
description: "Kind of pill.",
defaultValue: "neutral",
table: {
type: {summary: `"neutral" | "accent"`},
type: {
summary: `"neutral" | "accent | "info" | "success" |
"warning" | "critical"`,
},
defaultValue: {summary: "neutral"},
},
type: {
name: "enum",
value: ["neutral", "accent"],
value: [
"neutral",
"accent",
"info",
"success",
"warning",
"critical",
],
required: false,
},
},
Expand Down
Loading
Loading