Fixes for VK_EXT_extended_dynamic_state. #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdavis5e
requested changes
Oct 16, 2023
- MVKPipeline only work around zero stride if stride is static. - Ensure dynamic vertex stride is not enabled on builds before Xcode 15. - Add MVKRenderStateType::LineWidth for track all default options (unrelated).
billhollings
force-pushed
the
VK_EXT_extended_dynamic_state-fixes
branch
from
b455fa2 to
d706ed0
Compare
cdavis5e
approved these changes
Oct 17, 2023
tycho
reviewed
Oct 18, 2023
| setConfigurationResult(reportError(VK_ERROR_INITIALIZATION_FAILED, "Under Metal, vertex attribute binding strides must be aligned to %llu bytes.", mtlVtxStrideAlignment)); | ||
| // Vulkan allows any stride, but Metal requires multiples of 4 on older GPUs. | ||
| if (isVtxStrideStatic && (pVKVB->stride % _device->_pMetalFeatures->vertexStrideAlignment) != 0) { | ||
| setConfigurationResult(reportError(VK_ERROR_INITIALIZATION_FAILED, "Under Metal, vertex attribute binding strides must be aligned to %llu bytes.", _device->_pMetalFeatures->vertexStrideAlignment)); | ||
| return false; |
There was a problem hiding this comment.
FYI, there's some significant indentation inconsistency here.
There was a problem hiding this comment.
It's the typical tab-spacing issue. Everything is aligned when tab-spacing is set to 4. Github uses 8.
We never got around to mechanically enforce formatting. Formatting consistency is maintained by the devs, and some use spaces instead of tabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKPipelineonly work around zero stride if stride is static.MVKRenderStateType::LineWidthfor track all default options (unrelated).Fixes issue #2041.