Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce disk space consumed after running fetchDependencies. #2047

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

billhollings
Copy link
Contributor

@billhollings billhollings commented Oct 24, 2023

  • Add --keep-cache option to control whether or not to retain the External/build/Intermediates directory (default not retained).
  • Export KEEP_CACHE & SKIP_PACKAGING to be available within scripts used by ExternalDependencies Xcode builds.
  • Move BLD_SPECIFIED to build() instead of build_impl() to avoid updating it from background thread (which will fail).
  • Update MoltenVK version to 1.2.7 (unrelated).
  • Add CompilerMSL::Options::replace_recursive_inputs to pipeline cache (unrelated).
  • Update GitHub CI to Xcode 15.0.
  • Update Whats_new.md document.

@billhollings billhollings requested a review from cdavis5e October 24, 2023 00:05
Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor quibbles.

fetchDependencies Outdated Show resolved Hide resolved
fetchDependencies Outdated Show resolved Hide resolved
@billhollings billhollings force-pushed the reduce-deps-disk-space branch from 1ed1cb7 to 07aec52 Compare October 24, 2023 18:55
- Add --keep-cache option to control whether or not to retain the
  External/build/Intermediates directory (default not retained).
- Export KEEP_CACHE & SKIP_PACKAGING to be available within scripts
  used by ExternalDependencies Xcode builds.
- Move BLD_SPECIFIED to build() instead of build_impl() to avoid
  updating it from background thread (which will fail).
- Update MoltenVK version to 1.2.7 (unrelated).
- Add CompilerMSL::Options::replace_recursive_inputs to pipeline cache (unrelated).
- Update GitHub CI to Xcode 15.0.
- Update Whats_new.md document.
@billhollings billhollings force-pushed the reduce-deps-disk-space branch from 07aec52 to e693a0a Compare October 24, 2023 20:28
@billhollings billhollings merged commit bb914fa into KhronosGroup:main Oct 25, 2023
5 checks passed
@billhollings billhollings deleted the reduce-deps-disk-space branch October 25, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants