Don't make texture views where not necessary

[etang-cw]

This is mainly to work around a bug in macOS Sonoma where Radeon Pro 580Xs read black if you attempt to sample a D24S8 texture through a texture view that was previously copied from (so texture goes from copy source → shader read with texture view) [FB13342692]

But less texture views also makes things easier to track in the Xcode shader debugger, so might as well apply it always

[billhollings]

Thanks very much for catching this, and suggesting an improvement.

This is a bit odd though. Under what conditions does [baseTexture pixelFormat] == mtlPixFmt work, but the check, a couple of lines above, here doesn't?

MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKImage.mm

Line 86 in ab84de5

if (mtlPixFmt == _mtlPixFmt) { return _image->getMTLTexture(_planeIndex); }

Also a couple of nits about with formatting.

[billhollings]

MoltenVK convention is to use Obj-C property . syntax where possible, and avoid hanging if-statements. Please use baseTexture.pixelFormat, and wrap the if & else content statements in {} (and with the braces on the same line as the if & else where possible). See elsewhere for examples.

[etang-cw]

Looks like the issue was actually "fixed" by an update to the game that happened while I was testing and slightly changed how the game renders, hiding the issue. The actual reason for the texture view was that it needed a R001 swizzle, so we'll have to wait for Apple to fix the bug.