MVKDevice: Correct some required limits. #2076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
wideLines
feature isn't supported, thenlineWidthGranularity
must be zero.
If the
fullDrawIndexUint32
feature is supported, thenmaxDrawIndexedIndexValue
must beUINT32_MAX
. I had originally donethis when I turned the feature on, but for a while now, we've been
setting it to one less, because primitive restart can't be disabled and
the value is defined to exclude primitive restart.
The wording in the spec is ambiguous. The description of
maxDrawIndexedIndexValue
says:But the description of
fullDrawIndexUint32
says:It's unclear whether it means that the primitive restart index is to be
ignored, or the maximum draw index must account for it.
The alternative is to disable
fullDrawIndexUint32
because we cannotset
maxDrawIndexedIndexValue
toUINT32_MAX
; but that might misleadprograms into thinking that we only support 24-bit vertex indices.
Fixes the
dEQP-VK.info.device_properties
test.