Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI to use the cl_khr_unified_svm headers #2180

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

bashbaug
Copy link
Contributor

Updates CI to use headers with support for the cl_khr_unified_svm extension in the cl_khr_unified_svm branch.

Note that this PR targets the cl_khr_unified_svm branch, not the main branch.

@bashbaug bashbaug requested a review from kpet December 10, 2024 18:45
Copy link
Contributor

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should figure out what needs to change to get rid of the code format check issue. Rebase the cl_khr_unified_svm branch?

@bashbaug
Copy link
Contributor Author

We should figure out what needs to change to get rid of the code format check issue. Rebase the cl_khr_unified_svm branch?

Hmm, interesting. For now, I've updated the CI script to also check formatting against the cl_khr_unified_svm branch rather than the main branch. Updating the cl_khr_unified_svm branch may have worked too, but I think this is a more robust solution.

With this update the formatting check is now passing.

Copy link
Contributor

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works!

@bashbaug bashbaug merged commit 7b966bb into KhronosGroup:cl_khr_unified_svm Dec 10, 2024
9 checks passed
@bashbaug bashbaug deleted the update-ci-headers branch December 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants