Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: Choose where Shaders are generated #2226

Merged
merged 1 commit into from
Jan 14, 2025
Merged

vulkan: Choose where Shaders are generated #2226

merged 1 commit into from
Jan 14, 2025

Conversation

joshqti
Copy link
Contributor

@joshqti joshqti commented Jan 13, 2025

  • generate spv files into VULKAN_TEST_RESOURCES directory
  • works with change that generates spv at build time

@joshqti
vulkan: Choose where Shaders are generated
1ef688e 
- generate spv files into VULKAN_TEST_RESOURCES directory
- works with change that generates spv at build time

Change-Id: Ief5af8d5ff7d113d571102b048999f0477113415
bashbaug
bashbaug approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as discussed in the January 14th memory subgroup.

@bashbaug bashbaug merged commit a7db9a4 into KhronosGroup:main Jan 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshqti @bashbaug