Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Recom RAC20-xxDK Dual Output Parts #3090

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Add Recom RAC20-xxDK Dual Output Parts #3090

merged 3 commits into from
Sep 24, 2020

Conversation

Werni2A
Copy link
Contributor

@Werni2A Werni2A commented Sep 24, 2020

Datasheet

image


⚠️ Deprecation warning

In preparation for the KiCad v6 release this repository will be locked down on Sept 1, 2020. No new pull requests will be accepted. Existing pull requests can be worked on until Oct 1, 2020. Changes breaking v5.1 compatibility can be merged starting Sept 1, 2020.

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).

We plan to convert the library to the new v6 S-expr format after it is imported to GitLab. That also means that old pull requests will need to be redone with the v6 format if they are not merged before then.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@repo-lockdown
Copy link

repo-lockdown bot commented Sep 24, 2020

This repository does not accept pull requests at this time, see the README for details.

@repo-lockdown repo-lockdown bot closed this Sep 24, 2020
@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 24, 2020

@myfreescalewebpage you merged the RAC-20 single output parts, this PR adds the remaining dual output parts of the series. Maybe you also want to take a look at this one. No pressure :)

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library garlic labels Sep 24, 2020
@myfreescalewebpage
Copy link
Collaborator

I will take this, this is a great ddition

@myfreescalewebpage
Copy link
Collaborator

Can you solve the branch conflict now, the PR is opened

@myfreescalewebpage myfreescalewebpage self-assigned this Sep 24, 2020
@Werni2A Werni2A closed this Sep 24, 2020
@Werni2A Werni2A reopened this Sep 24, 2020
@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 24, 2020

@myfreescalewebpage Not sure why it was closed but now the conflict should be fixed.

@myfreescalewebpage
Copy link
Collaborator

The repo is locked and all new PR are automatically closed.

@myfreescalewebpage
Copy link
Collaborator

About your symbol, only one comment:

  • It's too large, please make the symbol the same width than the single output version

Joel

@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 24, 2020

Is there some guideline according to the naming of the symbol pins in AC/DCs? E.g. should all symbols in the lib have the same name for output pins or should be exactly as in the datasheet? One of the symbols should be adjusted.

Btw. I reduced the symbol size.

image

@myfreescalewebpage
Copy link
Collaborator

Is there some guideline according to the naming of the symbol pins in AC/DCs? E.g. should all symbols in the lib have the same name for output pins or should be exactly as in the datasheet?

Not related to converter only, all symbol should carefully follow the datasheet. Else this is a nice mess !!! We just ask people to copy/paste the names.

One of the symbols should be adjusted.

Which one ?

@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 24, 2020

Then I need to fix #2692 you merged earlier and this PR.

I will address this tomorrow afternoon.

Notes for myself:

image

@myfreescalewebpage
Copy link
Collaborator

Ohhh good point.

For the first subject, we also do not create pin name too much long so here it is accepted to keep AC(L) and AC(N).
For the second subject, you're right, and I notice RAC01 series in the lib has the same problem. If you create a pull request ping me and I will review it. Else, this is not an important trouble.

Joel

Merging this PR now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library garlic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants