Merge pull request #36 from Kicer86/cleanups

Docs and code cleanup
Kicer86 · Dec 9, 2023 · 15548d3 · 15548d3
2 parents 934f3f7 + a6533d2
commit 15548d3
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -21,9 +21,9 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 include(GenerateExportHeader)
 
-option(CppRestAPI_QtBackend "Qt backend for GitHubApi" OFF)
-option(CppRestAPI_CurlBackend "libcurl backend for GitHubApi" OFF)
-option(CppRestAPI_Tests "Enable GitHubApi tests. Forces both CppRestAPI_QtBackend and CppRestAPI_CurlBackend to be ON" OFF)
+option(CppRestAPI_QtBackend "Qt backend for CppRestAPI" OFF)
+option(CppRestAPI_CurlBackend "libcurl backend for CppRestAPI" OFF)
+option(CppRestAPI_Tests "Enable CppRestAPI tests. Forces both CppRestAPI_QtBackend and CppRestAPI_CurlBackend to be ON" OFF)
 
 if(CppRestAPI_Tests)
     set(CppRestAPI_QtBackend ON)

diff --git a/include/cpp_restapi/curl_connection.hpp b/include/cpp_restapi/curl_connection.hpp
@@ -6,8 +6,8 @@
 #include "cpp_restapi_export.h"
 
 
-namespace cpp_restapi { namespace CurlBackend {
-
+namespace cpp_restapi::CurlBackend
+{
     class CPP_RESTAPI_EXPORT Connection: public BaseConnection
     {
         public:
@@ -20,7 +20,6 @@ namespace cpp_restapi { namespace CurlBackend {
 
             std::pair<std::string, std::string> fetchPage(const std::string& request) override;
     };
-
-}}
+}
 
 #endif
diff --git a/include/cpp_restapi/qt_connection.hpp b/include/cpp_restapi/qt_connection.hpp
@@ -12,8 +12,8 @@
 
 class QNetworkAccessManager;
 
-namespace cpp_restapi { namespace QtBackend {
-
+namespace cpp_restapi::QtBackend
+{
     class CPP_RESTAPI_EXPORT Connection: public QObject, public BaseConnection
     {
         public:
@@ -31,7 +31,6 @@ namespace cpp_restapi { namespace QtBackend {
 
             QNetworkRequest prepareRequest();
     };
-
-}}
+}
 
 #endif
diff --git a/src/curl_backend/connection.cpp b/src/curl_backend/connection.cpp
@@ -29,7 +29,7 @@ namespace cpp_restapi::CurlBackend
     }
 
 
-    std::pair<std::string, std::string> cpp_restapi::CurlBackend::Connection::fetchPage(const std::string& page)
+    std::pair<std::string, std::string> Connection::fetchPage(const std::string& page)
     {
         std::string result;
         std::string header_links;